Merged
Conversation
This reverts commit 7382fd9.
bring develop to master
optimized imports
Cleared videos.json
I should probably also fix my git because I hate making commits on GitHub. Signed-off-by: BlockArchitech <hello@blockarchitech.com>
Documentation url
fix: install.sh might break python environments
update version and handle multiple post_ids correctly
"Add background video" option added to GUI
Thank you @JvSdv!
Thank you @jotonedev!
# Conflicts: # main.py # reddit/subreddit.py # requirements.txt # utils/subreddit.py
Updates the requirements on [pillow](https://github.com/python-pillow/Pillow) to permit the latest version. - [Release notes](https://github.com/python-pillow/Pillow/releases) - [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst) - [Commits](python-pillow/Pillow@9.3.0...9.4.0) --- updated-dependencies: - dependency-name: pillow dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Simon <65854503+OpenSourceSimon@users.noreply.github.com>
* feat: tiktok sessionId can be specified in the config.toml * feat: tiktok sessionId can be specified in the config.toml * Various improvements and optimizations * Add default argument * Remove an used variable * Code reformatted with black * Fixed all problems pointed out by pylint * Update TTS/TikTok.py * Apply suggestions from code review Co-authored-by: Simon <65854503+OpenSourceSimon@users.noreply.github.com> * chore: add default value for tiktok_voice Co-authored-by: Jose Collado <jose@collado.pw> Co-authored-by: Simon <65854503+OpenSourceSimon@users.noreply.github.com> Co-authored-by: Callum Leslie <github@cleslie.uk> Co-authored-by: Callum Leslie <git@cleslie.uk>
|
synonyms for work of art |
Contributor
|
Finally! |
callumio
reviewed
Jan 3, 2023
Collaborator
callumio
left a comment
There was a problem hiding this comment.
I don't really have time to go through all of this in depth or test, but overall it looks good.
Can you confirm that :
- all the code has been formatted to match the style guideline?
requirements.txtis up to date
The entire project would benefit greatly from better typehinting, but that can be done at a later date.
P.S. the mp3's really should never have been commited to git and rather downloaded as needed, but they're in there now so no point removing them.
callumio
reviewed
Jan 3, 2023
Collaborator
|
I can't say anything except for what Callum said |
Co-authored-by: Callum Leslie <git@cleslie.uk>
| # Add background video | ||
| def add_background(youtube_uri, filename, citation, position): | ||
| # Validate YouTube URI | ||
| regex = re.compile(r"(?:\/|%3D|v=|vi=)([0-9A-z\-_]{11})(?:[%#?&]|$)").search( |
Check warning
Code scanning / CodeQL
Overly permissive regular expression range
Add electro199 to developers and added fonts license
callumio
approved these changes
Jan 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After 5-6 months it's finally here! Version 3.0 includes loads of new features and bug fixes, here's a quick list: