Skip to content

Added the story mode with 2 methods and add min comment lenght#1288

Merged
OpenSourceSimon merged 57 commits intoelebumm:developfrom
electro199:master
Dec 19, 2022
Merged

Added the story mode with 2 methods and add min comment lenght#1288
OpenSourceSimon merged 57 commits intoelebumm:developfrom
electro199:master

Conversation

@electro199
Copy link
Copy Markdown
Contributor

@electro199 electro199 commented Oct 6, 2022 •
edited by OpenSourceSimon
Loading

Added the story mode with two options! The first option is only a screenshot of the post description (looks ugly with long posts). The second option generates images for every sentence.

I also added minimum comment length sorting feature

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes follow the existing code-style
  • My changes are relevant to the project
  • My changes generate no new warnings

Any other information (e.g how to test the changes)

It's a big feature and it needs to be tested a lot.

@electro199 electro199 closed this Oct 6, 2022
@electro199 electro199 reopened this Oct 6, 2022
@electro199 electro199 marked this pull request as ready for review October 6, 2022 11:52
@OpenSourceSimon OpenSourceSimon changed the base branch from master to develop October 6, 2022 12:29
@electro199
Copy link
Copy Markdown
Contributor Author

electro199 commented Oct 6, 2022

I have solve conflicts

OpenSourceSimon
OpenSourceSimon reviewed Oct 6, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@OpenSourceSimon OpenSourceSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but I have a couple of questions. Also, this needs to be tested

Comment thread video_creation/screenshot_downloader.py
Comment thread utils/subreddit.py Outdated
Comment thread TTS/engine_wrapper.py Outdated
@OpenSourceSimon OpenSourceSimon changed the title Added the stroy mode with two method and add min comment lenght Added the story mode with 2 methods and add min comment lenght Oct 7, 2022
OpenSourceSimon
OpenSourceSimon requested changes Oct 11, 2022
View reviewed changes
Comment thread utils/imagenarator.py Outdated
@JasonLovesDoggo
Copy link
Copy Markdown
Collaborator

JasonLovesDoggo commented Oct 11, 2022

Try using https://moviepy-tburrows13.readthedocs.io/en/latest/_modules/moviepy/video/fx/scroll.html

Instead of multiple screenshots

@electro199
Copy link
Copy Markdown
Contributor Author

electro199 commented Oct 11, 2022 •
edited
Loading

Try using https://moviepy-tburrows13.readthedocs.io/en/latest/_modules/moviepy/video/fx/scroll.html

Instead of multiple screenshots

yes possible it looks more like comment mode that's why I choose this approach

@ahelby
Copy link
Copy Markdown

ahelby commented Oct 15, 2022

When will this be released? Or How can I at least get the beta version of this to be working?

@OpenSourceSimon
Copy link
Copy Markdown
Collaborator

OpenSourceSimon commented Oct 15, 2022

When will this be released? Or How can I at least get the beta version of this to be working?

Hey, I hope we can release this soon. But it needs to be tested a lot because it's a big feature. I would recommend to join Lewis' Discord server, more information about testing the story mode is there!

@github-actions github-actions Bot added the stale label Oct 22, 2022
@github-actions github-actions Bot added stale and removed stale labels Dec 9, 2022
@OpenSourceSimon OpenSourceSimon added this to the 2.5 milestone Dec 17, 2022
@OpenSourceSimon OpenSourceSimon added the enhancement New feature or request label Dec 17, 2022
OpenSourceSimon
OpenSourceSimon reviewed Dec 19, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@OpenSourceSimon OpenSourceSimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Can you fix the things I reviewed? Then I'll finally merge

Comment thread main.py Outdated
Comment thread TTS/engine_wrapper.py Outdated
@OpenSourceSimon OpenSourceSimon merged commit e30eaf7 into elebumm:develop Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OpenSourceSimon OpenSourceSimon OpenSourceSimon approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request keep

Projects

None yet

Milestone

2.5

Development

Successfully merging this pull request may close these issues.

5 participants

@electro199 @JasonLovesDoggo @ahelby @OpenSourceSimon @gabx03