Skip to content

Adding prawcore to the requirements#1242

Merged
JasonLovesDoggo merged 8 commits intoelebumm:developfrom
NoFailer:patch-1
Sep 10, 2022
Merged

Adding prawcore to the requirements#1242
JasonLovesDoggo merged 8 commits intoelebumm:developfrom
NoFailer:patch-1

Conversation

@NoFailer
Copy link
Copy Markdown
Contributor

@NoFailer NoFailer commented Sep 8, 2022 •
edited
Loading

Description

Multiple people on the discord ran into the issue that an error message would come up saying ModuleNotFoundError: No module named 'prawcore'. I was told praw itself is supposed to install it but apparently it does not? I cannot exactly verify if the people actually followed the steps correctly. Json told me to make a PR for it :) I took the value for the requirements.txt from here.

- Adri

Issue Fixes

ModuleNotFoundError: No module named 'prawcore'

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

Go through the installation steps.

hammamikhairi and others added 7 commits August 19, 2022 19:04
@hammamikhairi
better issues
19a6cb0
@hammamikhairi
removed blank issue restriction
e83a63b
@JasonLovesDoggo
Merge pull request #1184 from hammamikhairi/feat/better-issues
9365e89 
better issues
@FreebieII
Changed Discord Discriminator
6b2f577
@FreebieII
Merge pull request #1236 from elebumm/Update--Discord--Discrim
518f946 
Changed Discord Discriminator
@NoFailer
Adding prawcore to the requirements
3e804b9 
Multiple people on the discord ran into the issue that an error message would come up saying "ModuleNotFoundError: No module names 'prawcore'". I was told praw itself is supposed to install it but apparently it does not? I cannot verify if the people actually followed the steps correctly. Json told me to make a PR for it :) I took the value for the requirements.txt from here: https://pypi.org/project/prawcore/
@NoFailer
Changed version of prawcore
43eb96c 
After discussing it with Json. Changed version to 2.3.0.
@NoFailer
Copy link
Copy Markdown
Contributor Author

NoFailer commented Sep 8, 2022

After discussing it with Json. Changed version to 2.3.0.

@JasonLovesDoggo JasonLovesDoggo changed the base branch from master to develop September 8, 2022 12:36
@JasonLovesDoggo
Copy link
Copy Markdown
Collaborator

JasonLovesDoggo commented Sep 8, 2022

Please fix the merge conflicts

@NoFailer
Copy link
Copy Markdown
Contributor Author

NoFailer commented Sep 8, 2022

For some reason GitHub wants to merge 7 commits, 5 being from other people. No idea why it is doing that. Let me try to fix this.

@NoFailer
Copy link
Copy Markdown
Contributor Author

NoFailer commented Sep 8, 2022

No idea what is going on, given those merge conflicts come from changes I didn't do. I hope I resolved them correctly.

@NoFailer
Copy link
Copy Markdown
Contributor Author

NoFailer commented Sep 8, 2022 •
edited
Loading

I see what happened. The branch patch-1 created by GitHub is based on the current main branch. You changing the target of this merge to be the development branch then created merge issues because of the changes in that dev branch that have not been merged to main yet. That being said, I think my changes should be merged directly because the main branch is what the people are downloading and trying to install, leading to this error I am talking about.

@JasonLovesDoggo JasonLovesDoggo merged commit dcd0ff5 into elebumm:develop Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OpenSourceSimon OpenSourceSimon OpenSourceSimon approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NoFailer @JasonLovesDoggo @OpenSourceSimon @hammamikhairi @FreebieII