Fix: Correct video length#1221
Merged
JasonLovesDoggo merged 1 commit intoelebumm:developfrom Aug 31, 2022
rivenintech:develop
Merged
Fix: Correct video length#1221JasonLovesDoggo merged 1 commit intoelebumm:developfrom rivenintech:develop
JasonLovesDoggo merged 1 commit intoelebumm:developfrom
rivenintech:develop
Conversation
Collaborator
|
Lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every time I run the script, it leaves extra few seconds after it's done with the last comment (there is only a background video). I found out that it didn't remove the last clip when it exceeded the length limit (
self.last_clip_lengthis always0). I fixed it by adding one line that correctly changesself.last_clip_length.Issue Fixes
Fixes #1115 (not sure)
Examples
Before:
Before.mp4
After:
After.mp4