Bot can run multiple instances at the same time#1091
Merged
callumio merged 18 commits intoelebumm:developfrom Aug 9, 2022
Merged
Bot can run multiple instances at the same time#1091callumio merged 18 commits intoelebumm:developfrom
callumio merged 18 commits intoelebumm:developfrom
Conversation
callumio
requested changes
Jul 29, 2022
Collaborator
callumio
left a comment
There was a problem hiding this comment.
Looks good, just those few things that could be improved
JasonLovesDoggo
requested changes
Jul 30, 2022
Collaborator
Author
|
Any reason this isn't merged yet? |
Collaborator
Waiting for @callumio s review |
callumio
approved these changes
Aug 9, 2022
|
It keeps makes the same video in the different instace, is this only me? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With this pull request you can use the program multiple times at the same time. This is because the temp folder is determined per folder. For example: if the video id is 12356, then the temp folder is assets/temp/123456/png . If you run another instance with the id 67890 then the temp folder is assets/temp/67890/png .
Issue Fixes
None
Checklist:
Any other information (e.g how to test the changes)
None