Skip to content

Feat: Created option to add transition between comments#1041

Merged
JasonLovesDoggo merged 1 commit intoelebumm:developfrom
rivenintech:develop
Jul 19, 2022
Merged

Feat: Created option to add transition between comments#1041
JasonLovesDoggo merged 1 commit intoelebumm:developfrom
rivenintech:develop

Conversation

@rivenintech
Copy link
Copy Markdown
Contributor

Description

I created an option to add a transition (fade-in and fade-out) between the images of comments. Comments appear smoothly with the customizable length of transitions. You can set the length of the transitions in the range of 0-2 seconds, but I think anything bigger than 0.5 looks bad (best results with default value - 0.2).

Example:

What.comedian.has.never.ever.made.you.laugh.mp4

Issue Fixes

None

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

None

Created an option to add a transition (fadein and fadeout) between the images of comments. It makes videos look much more pleasant.
@JasonLovesDoggo
Copy link
Copy Markdown
Collaborator

That looks amazing I'm just going to review the code

@JasonLovesDoggo JasonLovesDoggo merged commit 0155841 into elebumm:develop Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants