Fix: Hide the "Click to see NSFW" button#1001
Merged
JasonLovesDoggo merged 1 commit intoelebumm:developfrom Jul 15, 2022
rivenintech:develop
Merged
Fix: Hide the "Click to see NSFW" button#1001JasonLovesDoggo merged 1 commit intoelebumm:developfrom rivenintech:develop
JasonLovesDoggo merged 1 commit intoelebumm:developfrom
rivenintech:develop
Conversation
Fixed this issue by making Playwright wait for page to fully load before clicking the button.
Collaborator
|
Seems good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The button "Click to see NSFW" was visible on screenshots. Clicking on the 'Yes' button on the first screen triggers reload, so by making Playwright wait for the page to fully load, we can make sure the button will be clicked.
Thanks to @drugsosos who thought about it - #991.
Issue Fixes
None
Checklist:
Any other information (e.g how to test the changes)
To test changes you just have to run the script with an NSFW post and check if the title screenshot doesn't have the "Click to see NSFW" button.