Skip to content

Fix: Hide the "Click to see NSFW" button#1001

Merged
JasonLovesDoggo merged 1 commit intoelebumm:developfrom
rivenintech:develop
Jul 15, 2022
Merged

Fix: Hide the "Click to see NSFW" button#1001
JasonLovesDoggo merged 1 commit intoelebumm:developfrom
rivenintech:develop

Conversation

@rivenintech
Copy link
Copy Markdown
Contributor

Description

The button "Click to see NSFW" was visible on screenshots. Clicking on the 'Yes' button on the first screen triggers reload, so by making Playwright wait for the page to fully load, we can make sure the button will be clicked.

Thanks to @drugsosos who thought about it - #991.

Issue Fixes

None

Checklist:

  • I am pushing changes to the develop branch
  • I am using the recommended development environment
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have formatted and linted my code using python-black and pylint
  • I have cleaned up unnecessary files
  • My changes generate no new warnings
  • My changes follow the existing code-style
  • My changes are relevant to the project

Any other information (e.g how to test the changes)

To test changes you just have to run the script with an NSFW post and check if the title screenshot doesn't have the "Click to see NSFW" button.

Fixed this issue by making Playwright wait for page to fully load before clicking the button.
Copy link
Copy Markdown
Contributor

@efa2d19 efa2d19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should work

@JasonLovesDoggo
Copy link
Copy Markdown
Collaborator

Seems good to me

@JasonLovesDoggo JasonLovesDoggo merged commit 429881e into elebumm:develop Jul 15, 2022
@rivenintech rivenintech deleted the develop branch July 15, 2022 19:28
@rivenintech rivenintech restored the develop branch July 19, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants