Don't compare an issueSet with nil (temporalio#5563)

MichaelSnowden · web-flow · commit a98b60e3f43f · 2024-03-20T09:05:00.000-07:00
## What changed?  There was a small issue in temporalio#5523 where we check an "issue set" against nil in the outgoing service registry code. The issue set is supposed to track a list of request issues to form one big invalid argument error if its length is greater than zero. However, we had code that looked like this: ```go if issues := getIssuesFromCommonRequest(req); issues != nil { return nil, issues.GetError() } ``` Which works because we return a nil issues set if there's no issues, but, technically, we could have a non-nil issues set with no issues, so it should instead be something like this: ```go if err := getIssuesFromCommonRequest(req).GetError(); err != nil { return nil, err } ``` ## Why?  ## How did you test it?  ## Potential risks  ## Documentation  ## Is hotfix candidate?
diff --git a/common/nexus/outgoing_service_registry.go b/common/nexus/outgoing_service_registry.go
@@ -101,8 +101,8 @@ func (h *OutgoingServiceRegistry) Get(
 	ctx context.Context,
 	req *operatorservice.GetNexusOutgoingServiceRequest,
 ) (*operatorservice.GetNexusOutgoingServiceResponse, error) {
-	if issues := findIssuesForCommonRequest(req); issues != nil {
-		return nil, issues.GetError()
+	if err := findIssuesForCommonRequest(req).GetError(); err != nil {
+		return nil, err
 	}
 	response, err := h.namespaceService.GetNamespace(ctx, &persistence.GetNamespaceRequest{
 		Name: req.Namespace,
@@ -213,8 +213,8 @@ func (h *OutgoingServiceRegistry) Delete(
 	ctx context.Context,
 	req *operatorservice.DeleteNexusOutgoingServiceRequest,
 ) (*operatorservice.DeleteNexusOutgoingServiceResponse, error) {
-	if errorMessageSet := findIssuesForCommonRequest(req); errorMessageSet != nil {
-		return nil, errorMessageSet.GetError()
+	if err := findIssuesForCommonRequest(req).GetError(); err != nil {
+		return nil, err
 	}
 	response, err := h.namespaceService.GetNamespace(ctx, &persistence.GetNamespaceRequest{
 		Name: req.Namespace,
@@ -374,15 +374,15 @@ type commonRequest interface {
 	GetName() string
 }
 
-func findIssuesForCommonRequest(req commonRequest) issueSet {
+func findIssuesForCommonRequest(req commonRequest) *issueSet {
 	var set issueSet
 	if req.GetNamespace() == "" {
 		set.Append(IssueNamespaceNotSet)
 	}
 	if req.GetName() == "" {
 		set.Append(IssueNameNotSet)
 	}
-	return set
+	return &set
 }
 
 type upsertRequest interface {
