Use pagination token in loadClusterInformationFromStore (temporalio#5608)

MichaelSnowden · web-flow · commit 4222a2aecfc3 · 2024-03-27T02:39:33.000Z
## What changed?  We forgot to use the next page token when loading all clusters in the cluster metadata loader during startup. This probably doesn't matter because most people don't have more than 100 clusters, but it looks like this code would trigger an infinite loop if that were the case. ## Why?  ## How did you test it?  You can see the infinite loop in action if you set the page size to 1 for the xdc cluster setup by running `make install-schema-xdc && make start-xdc-cluster-a` because it has 3 clusters, which means 2 remote clusters, so a page size of 1 will not get all clusters, causing the paginating iterator to call the func again. <img width="945" alt="image" src="https://github.com/temporalio/temporal/assets/5942963/11bb683c-588c-476f-9163-46405452755f"> If I actually use the paginationToken, you can see that the issue goes away. <img width="1082" alt="image" src="https://github.com/temporalio/temporal/assets/5942963/3ce37d7b-aaeb-464b-a8d7-db6413176391"> ## Potential risks  ## Documentation  ## Is hotfix candidate?
diff --git a/temporal/fx.go b/temporal/fx.go
@@ -683,7 +683,7 @@ func loadClusterInformationFromStore(ctx context.Context, svc *config.Config, cl
 	iter := collection.NewPagingIterator(func(paginationToken []byte) ([]interface{}, []byte, error) {
 		request := &persistence.ListClusterMetadataRequest{
 			PageSize:      100,
-			NextPageToken: nil,
+			NextPageToken: paginationToken,
 		}
 		resp, err := clusterMsg.ListClusterMetadata(ctx, request)
 		if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -683,7 +683,7 @@ func loadClusterInformationFromStore(ctx context.Context, svc *config.Config, cl`
`683`	`683`	`iter := collection.NewPagingIterator(func(paginationToken []byte) ([]interface{}, []byte, error) {`
`684`	`684`	`request := &persistence.ListClusterMetadataRequest{`
`685`	`685`	`PageSize: 100,`
`686`		`- NextPageToken: nil,`
	`686`	`+ NextPageToken: paginationToken,`
`687`	`687`	`}`
`688`	`688`	`resp, err := clusterMsg.ListClusterMetadata(ctx, request)`
`689`	`689`	`if err != nil {`