Skip to content

Enable secret for the identified fields in multiple packages - #9009

Merged
ritalwar merged 19 commits into
elastic:mainfrom
ritalwar:secret_migration_1305
Feb 13, 2024
Merged

Enable secret for the identified fields in multiple packages#9009
ritalwar merged 19 commits into
elastic:mainfrom
ritalwar:secret_migration_1305

Conversation

@ritalwar

@ritalwar ritalwar commented Jan 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed commit message

  • Enable secret for identified sensitive fields.
  • Update package-spec to 3.0.2 for most packages to utilize the validation checks for secrets.
  • Omit the package-spec update to 3.0.2 for the aws package due to additional validation check involving dynamic mappings for nested fields in the waf datastream.
  • Update Kibana version condition to 8.12 for packages on versions 8.10-8.11, as 8.12 resolves all secret-related issues.
  • For packages < 8.10.0, retain existing Kibana version. Changelog descriptions for these packages indicate that secrets are supported from version 8.12, allowing users to upgrade stack at their discretion.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

How to test this PR locally

Related issues

Screenshots

@ritalwar ritalwar added the enhancement New feature or request label Jan 30, 2024
@ritalwar ritalwar self-assigned this Jan 30, 2024
@elasticmachine

elasticmachine commented Jan 30, 2024 •
edited
Loading

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

ritalwar and others added 13 commits January 30, 2024 15:12
@ritalwar
ritalwar marked this pull request as ready for review February 7, 2024 10:23
@ritalwar
ritalwar requested review from a team as code owners February 7, 2024 10:23
ali786XI
ali786XI reviewed Feb 7, 2024
View reviewed changes
Comment thread packages/salesforce/manifest.yml Resolved
harnish-crest-data
harnish-crest-data approved these changes Feb 8, 2024
View reviewed changes

@harnish-crest-data harnish-crest-data left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kaiyan-sheng kaiyan-sheng mentioned this pull request Feb 22, 2024
Merged
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes
@agithomas agithomas agithomas approved these changes
+3 more reviewers
@andrewkroh andrewkroh andrewkroh approved these changes
@harnish-crest-data harnish-crest-data harnish-crest-data approved these changes
@ali786XI ali786XI ali786XI approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ritalwar ritalwar

Labels

enhancement New feature or request Integration:activemq ActiveMQ Integration:apache_tomcat Apache Tomcat Integration:aws AWS Integration:azure_app_service Azure App Service Integration:azure_application_insights Azure Application Insights Metrics Overview Integration:azure_billing Azure Billing Metrics Integration:azure_functions Azure Functions Integration:cassandra Cassandra Integration:ceph Ceph Integration:citrix_adc Citrix ADC Integration:cockroachdb CockroachDB Metrics Integration:golang Golang Integration:kafka_log Kafka Log Consumer Integration:kafka Kafka Integration:microsoft_sqlserver Microsoft SQL Server Integration:mongodb MongoDB Integration:mysql MySQL Integration:nginx Nginx Integration:oracle_weblogic Oracle WebLogic Integration:postgresql PostgreSQL Integration:prometheus_input Prometheus (Kubernetes) Integration:prometheus Prometheus Integration:rabbitmq RabbitMQ Logs and Metrics Integration:redis Redis Integration:salesforce Salesforce Integration:spring_boot Spring Boot Integration:system System Integration:vsphere VMware vSphere Integration:websphere_application_server WebSphere Application Server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ritalwar @elasticmachine @agithomas @zmoog @andrewkroh @harnish-crest-data @ali786XI