Skip to content

[aws] Add configuration option for TLD for httpjson inputs - #8027

Merged
kgeller merged 6 commits into
elastic:mainfrom
kgeller:aws-fix-hardcoded-.com
Oct 2, 2023
Merged

[aws] Add configuration option for TLD for httpjson inputs#8027
kgeller merged 6 commits into
elastic:mainfrom
kgeller:aws-fix-hardcoded-.com

Conversation

@kgeller

@kgeller kgeller commented Sep 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed commit message

[aws] Update guardduty, inspector, securityhub_findings and securityhub_insights httpjson configs to allow the configuration of the TLD. Default will be set to currently hardcoded value of amazonaws.com.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

New config option under the Advanced Settings

Screenshot 2023-09-29 at 9 55 39 AM

@kgeller
Add configuration option for tld for guardduty, inspector, securityhu…
feba401 
…b_findings and securityhub_insights httpjson configs
@kgeller kgeller added bug Something isn't working, use only for issues Team:Security-External Integrations Integration:aws AWS labels Sep 29, 2023
@kgeller kgeller self-assigned this Sep 29, 2023
@elasticmachine

elasticmachine commented Sep 29, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-10-02T14:01:58.116+0000

  • Duration: 53 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 212
Skipped 3
Total 215

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Sep 29, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (17/17) 💚
Files 94.444% (17/18) 👍 2.222
Classes 94.444% (17/18) 👍 2.222
Methods 86.047% (259/301) 👎 -5.909
Lines 86.075% (7566/8790) 👎 -3.061
Conditionals 100.0% (0/0) 💚

@kgeller

kgeller commented Sep 29, 2023

Copy link
Copy Markdown
Member Author

/test

@kgeller
kgeller marked this pull request as ready for review September 29, 2023 16:32
@kgeller
kgeller requested review from a team as code owners September 29, 2023 16:32
@elasticmachine

elasticmachine commented Sep 29, 2023

Copy link
Copy Markdown

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@kgeller

kgeller commented Sep 29, 2023

Copy link
Copy Markdown
Member Author

/test

bhapas
bhapas reviewed Oct 2, 2023
View reviewed changes
Comment thread packages/aws/changelog.yml Resolved
bhapas
bhapas reviewed Oct 2, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed to add this before. Sorry.

Can we add tld to the system test config [ something other than amazonaws.com as well ] and test this?

@kgeller

kgeller commented Oct 2, 2023

Copy link
Copy Markdown
Member Author

Can we add tld to the system test config [ something other than amazonaws.com as well ] and test this?

Added for the securityhub_findings datastream since that was where the issue was reported

bhapas
bhapas approved these changes Oct 2, 2023
View reviewed changes

@bhapas bhapas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zmoog
zmoog approved these changes Oct 2, 2023
View reviewed changes

@zmoog zmoog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgeller
kgeller merged commit af6c1ae into elastic:main Oct 2, 2023
@kgeller
kgeller deleted the aws-fix-hardcoded-.com branch October 2, 2023 15:27
@elasticmachine

elasticmachine commented Oct 2, 2023

Copy link
Copy Markdown

Package aws - 2.8.0 containing this change is available at https://epr.elastic.co/search?package=aws

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@kgeller
[aws] Add configuration option for TLD for httpjson inputs (elastic#8027
288562a 
)

* Add configuration option for tld for guardduty, inspector, securityhub_findings and securityhub_insights httpjson configs

* changelog

* switch to enhancement

* system test config for tld for securityhub_findings datastream

* syncing tld in docker-compose  with the system test config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zmoog zmoog zmoog approved these changes
@marc-gr marc-gr marc-gr approved these changes
@bhapas bhapas bhapas approved these changes

Assignees

@kgeller kgeller

Labels

bug Something isn't working, use only for issues Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kgeller @elasticmachine @zmoog @marc-gr @bhapas