Skip to content

[aws] Add missing fields in vpcflow logs - #6916

Merged
tdancheva merged 4 commits into
elastic:mainfrom
tdancheva:vpcflow-add-missing-fields
Jul 12, 2023
Merged

[aws] Add missing fields in vpcflow logs#6916
tdancheva merged 4 commits into
elastic:mainfrom
tdancheva:vpcflow-add-missing-fields

Conversation

@tdancheva

@tdancheva tdancheva commented Jul 11, 2023 •
edited by kaiyan-sheng
Loading

Copy link
Copy Markdown
Contributor

What does this PR do?

Adding missing S3 fields for vpcflow.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@tdancheva tdancheva added the enhancement New feature or request label Jul 11, 2023
@tdancheva
tdancheva marked this pull request as ready for review July 11, 2023 14:42
@tdancheva
tdancheva requested a review from a team as a code owner July 11, 2023 14:42
@tdancheva
tdancheva requested a review from kaiyan-sheng July 11, 2023 14:42
@elasticmachine

elasticmachine commented Jul 11, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-07-11T16:29:02.281+0000

  • Duration: 54 min 30 sec

Test stats 🧪

Test Results
Failed 0
Passed 194
Skipped 4
Total 198

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

kaiyan-sheng
kaiyan-sheng reviewed Jul 11, 2023
View reviewed changes

@kaiyan-sheng kaiyan-sheng left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!!!
What do you think about adding these field definitions into the existing fields.yml file? We can make them all under aws.s3 there.

@kaiyan-sheng

kaiyan-sheng commented Jul 11, 2023

Copy link
Copy Markdown

and we need to run elastic-package build 😬

@elasticmachine

elasticmachine commented Jul 11, 2023

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) ❕
Classes 93.75% (15/16) ❕
Methods 85.714% (240/280) ❕
Lines 85.925% (7387/8597) ❕
Conditionals 100.0% (0/0) 💚

@tdancheva

tdancheva commented Jul 11, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for working on this!!! What do you think about adding these field definitions into the existing fields.yml file? We can make them all under aws.s3 there.

Done! Passed all the checks. Is it okay?

@andrewkroh andrewkroh changed the title Add missing fields [aws] Add missing fields Jul 11, 2023
@kaiyan-sheng kaiyan-sheng changed the title [aws] Add missing fields [aws] Add missing fields in vpcflow logs Jul 11, 2023
harnish-crest-data
harnish-crest-data approved these changes Jul 12, 2023
View reviewed changes

@harnish-crest-data harnish-crest-data left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tdancheva
tdancheva merged commit ab16cb6 into elastic:main Jul 12, 2023
@tdancheva
tdancheva deleted the vpcflow-add-missing-fields branch July 12, 2023 07:19
@elasticmachine

elasticmachine commented Jul 12, 2023

Copy link
Copy Markdown

Package aws - 1.46.3 containing this change is available at https://epr.elastic.co/search?package=aws

@tdancheva tdancheva mentioned this pull request Jul 12, 2023
Closed
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
@tdancheva
[aws] Add missing fields in vpcflow logs (elastic#6916)
24511d3 
* Add missing fields

* Changelog and manifest

* Update vpcflow docs

* Update fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes
@harnish-crest-data harnish-crest-data harnish-crest-data approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request Integration:aws AWS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tdancheva @elasticmachine @kaiyan-sheng @harnish-crest-data @andrewkroh