Skip to content

[AWS] Migrate EBS dashboard visualizations to lenses - #5212

Merged
3 commits merged into
mainfrom
unknown repository
Feb 15, 2023
Merged

[AWS] Migrate EBS dashboard visualizations to lenses#5212
3 commits merged into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Feb 8, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

What does this PR do?

Migrates EBS visualizations to lenses.

Before:

ebs_before

After:

ebs_after

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine

elasticmachine commented Feb 8, 2023 •
edited
Loading

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-13T12:21:57.700+0000

  • Duration: 50 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 188
Skipped 4
Total 192

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Feb 8, 2023 •
edited
Loading

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (15/15) 💚
Files 93.75% (15/16) 👎 -6.25
Classes 93.75% (15/16) 👎 -6.25
Methods 86.131% (236/274) 👎 -13.869
Lines 85.925% (7387/8597) 👎 -3.205
Conditionals 100.0% (0/0) 💚

@ghost
ghost marked this pull request as ready for review February 9, 2023 09:51
@ghost
ghost requested review from a team as code owners February 9, 2023 09:51
@tommyers-elastic

tommyers-elastic commented Feb 9, 2023

Copy link
Copy Markdown
Contributor

looks good! are the region and volume id drop down filters using the deprecated input control panels though?

thanks

drewdaemon
drewdaemon reviewed Feb 9, 2023
View reviewed changes

@drewdaemon drewdaemon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. As has been mentioned, we should take this opportunity to migrate the deprecated "controls visualizations" to the native dashboard controls (doc).

@ghost

ghost commented Feb 13, 2023

Copy link
Copy Markdown
Author

I added the control groups and fixed first 2 panels width and position:

updated_ebs

drewdaemon
drewdaemon approved these changes Feb 13, 2023
View reviewed changes

@drewdaemon drewdaemon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

tommyers-elastic
tommyers-elastic approved these changes Feb 15, 2023
View reviewed changes

@tommyers-elastic tommyers-elastic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks gabriel!

@ghost
ghost merged commit 5fca8c0 into elastic:main Feb 15, 2023
@elasticmachine

elasticmachine commented Feb 15, 2023

Copy link
Copy Markdown

Package aws - 1.32.0 containing this change is available at https://epr.elastic.co/search?package=aws

bhapas pushed a commit to bhapas/integrations that referenced this pull request Feb 16, 2023
Gabriel Pop @bhapas
[AWS] Migrate EBS dashboard visualizations to lenses (elastic#5212)
fa5d3c2 
* add lenses

* add changelog entry and bump package version

* add control groups and fix dashboards width
@rameshelastic rameshelastic assigned ghost Jun 19, 2023
orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
Gabriel Pop
[AWS] Migrate EBS dashboard visualizations to lenses (elastic#5212)
532da11 
* add lenses

* add changelog entry and bump package version

* add control groups and fix dashboards width
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@elasticmachine @tommyers-elastic @drewdaemon @mrg-elastic