Skip to content

[AWS] Add "Data Granularity" parameter for metrics data streams - #4515

Merged
girodav merged 19 commits into
mainfrom
unknown repository
Jan 12, 2023
Merged

girodav merged 19 commits into
mainfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Oct 27, 2022

Copy link
Copy Markdown

What does this PR do?

Adds data_granularity parameter for metrics data streams and renames period parameter title to Collection Period.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@ghost ghost added Team:Cloud-Monitoring Label for the Cloud Monitoring team Integration:aws AWS labels Oct 27, 2022
@elasticmachine

elasticmachine commented Oct 27, 2022 •

Copy link
Copy Markdown

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-12T09:26:36.885+0000

  • Duration: 47 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 179
Skipped 3
Total 182

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine

elasticmachine commented Oct 28, 2022 •

Copy link
Copy Markdown

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine

elasticmachine commented Oct 28, 2022 •

Copy link
Copy Markdown

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (14/14) 💚
Files 93.333% (14/15) 👎 -4.2
Classes 93.333% (14/15) 👎 -4.2
Methods 85.214% (219/257) 👎 -5.384
Lines 96.022% (5914/6159) 👍 4.241
Conditionals 100.0% (0/0) 💚

@ghost
ghost marked this pull request as ready for review October 28, 2022 11:40
@ghost
ghost self-requested a review as a code owner October 28, 2022 11:40
Comment thread packages/aws/changelog.yml Resolved
Comment thread packages/aws/manifest.yml Resolved
@girodav

girodav commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

/test

2 similar comments
@girodav

girodav commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

/test

@girodav

girodav commented Nov 16, 2022

Copy link
Copy Markdown
Contributor

/test

@girodav

girodav commented Nov 17, 2022

Copy link
Copy Markdown
Contributor

CI failures probably related to elastic/fleet-server#2083

@girodav

girodav commented Jan 10, 2023

Copy link
Copy Markdown
Contributor

/test

@girodav
girodav merged commit c81ea06 into elastic:main Jan 12, 2023
@elasticmachine

Copy link
Copy Markdown

Package aws - 1.29.0 containing this change is available at https://epr.elastic.co/search?package=aws

orestisfl pushed a commit to orestisfl/integrations that referenced this pull request May 15, 2026
…tic#4515)

* [AWS] Add "Data Granularity" parameter for metrics data streams
* [AWS] Updated docs with info about how AWS APIs are used and cost considerations for metrics-related data streams

Co-authored-by: Davide Girardi <1390902+girodav@users.noreply.github.com>
Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Integration:aws AWS Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AWS] Add a new "Data Granularity" advanced parameter for metrics-related integrations

5 participants