Repository navigation
build: update goreleaser configuration file to version 2 - #366
Merged
fin09pcap merged 1 commit intoApr 29, 2025
Merged
Conversation
Signed-off-by: Ben Stickel <ben.stickel@elastic.co>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the goreleaser configuration file to version 2. The changes include:
- Adding a YAML schema comment and updating the version.
- Modifying the gomod proxy setting and archives configuration.
- Changing the snapshot and changelog configuration to match the new version 2 schema.
Comments suppressed due to low confidence (2)
.goreleaser.yaml:11
- Ensure that changing the gomod proxy setting to 'false' complies with the intended behavior for module resolution in version 2. If this change is deliberate, consider adding documentation to clarify the reasoning.
proxy: false
.goreleaser.yaml:63
- Verify that replacing 'skip: true' with 'disable: true' in the changelog section reflects the correct behavior in version 2. Adjust documentation if the new field has different semantics.
disable: true
robinverduijn
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
It seems the Nancy scanner isn't too happy, but I don't see how that's caused specifically by your changes. I'll approve in case you need to force the merge in order to move on with things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.goreleaser.yamlforversion 2configuration.