fix missing _basic_globals / _basic_globals_id#2
Merged
Conversation
edtechd
added a commit
that referenced
this pull request
Jul 4, 2015
fix missing _basic_globals / _basic_globals_id
Owner
|
It looks like a workaround and I am not sure that it is correct. I will do some tests a bit later. |
Author
|
Maybe this gives a clue. If I add #include "ext/standard/basic_functions.h" at the very beginning of library.c I am getting these errors: php_filestat.h is included in basic_functions.h at line 31. |
Author
|
See #3 |
Author
|
I set up a redis server on a Centos6 machine and connected to that server from my laptop. No problems: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one makes it compile. I tried including "ext/standard/basic_functions.h", but that caused other errors, so I copied only the essential part. Including basic_functions.h however is preferable if you or me can make that to work.