Sourcery refactored master branch - #1
Open
sourcery-ai[bot] wants to merge 1 commit into
Open
Conversation
Comment on lines
-95
to
+99
| print('%s removed ...' % item) | ||
| print(f'{item} removed ...') | ||
| except OSError: | ||
| try: | ||
| shutil.rmtree(item) | ||
| print('%s/ removed ...' % item) | ||
| print(f'{item}/ removed ...') |
Author
There was a problem hiding this comment.
Function rmtree_glob refactored with the following changes:
- Replace interpolated string formatting with f-string (
replace-interpolation-with-fstring)
Comment on lines
-74
to
-81
| pages = [ | ||
| HelpPage(parent=parent, | ||
| bitmap=wx.Bitmap(bitmap_file), | ||
| caption=caption) | ||
| return [ | ||
| HelpPage(parent=parent, bitmap=wx.Bitmap(bitmap_file), caption=caption) | ||
| for [caption, bitmap_file] in help_images_list | ||
| ] | ||
|
|
||
| return pages |
Author
There was a problem hiding this comment.
Function page_list refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
|
|
||
| def __repr__(self): | ||
| return "Vector(" + tuple.__repr__(self) + ")" | ||
| return f"Vector({tuple.__repr__(self)})" |
Author
There was a problem hiding this comment.
Function Vector.__repr__ refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
| def push(self, command): | ||
| more = self.runsource(command, self.filename) | ||
| return more | ||
| return self.runsource(command, self.filename) |
Author
There was a problem hiding this comment.
Function Console.push refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-133
to
-136
| if more: | ||
| pass # prompt = sys.ps2 | ||
| else: | ||
| pass # prompt = sys.ps1 |
Author
There was a problem hiding this comment.
Function Console.interact refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if) - Remove redundant pass statement (
remove-redundant-pass)
This removes the following comments ( why? ):
# prompt = sys.ps1
# prompt = sys.ps2
Comment on lines
-1258
to
+1212
| if redirect: | ||
| sys.stdin = self.reader | ||
| else: | ||
| sys.stdin = self.stdin | ||
| sys.stdin = self.reader if redirect else self.stdin |
Author
There was a problem hiding this comment.
Function Shell.redirectStdin refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-1265
to
+1216
| if redirect: | ||
| sys.stdout = PseudoFileOut(self.writeOut) | ||
| else: | ||
| sys.stdout = self.stdout | ||
| sys.stdout = PseudoFileOut(self.writeOut) if redirect else self.stdout |
Author
There was a problem hiding this comment.
Function Shell.redirectStdout refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-1272
to
+1220
| if redirect: | ||
| sys.stderr = PseudoFileErr(self.writeErr) | ||
| else: | ||
| sys.stderr = self.stderr | ||
| sys.stderr = PseudoFileErr(self.writeErr) if redirect else self.stderr |
Author
There was a problem hiding this comment.
Function Shell.redirectStderr refactored with the following changes:
- Replace if statement with if expression (
assign-if-exp)
Comment on lines
-1279
to
+1228
| if self.GetSelectionStart() != self.GetSelectionEnd() \ | ||
| and self.GetSelectionStart() >= self.promptPosEnd \ | ||
| and self.GetSelectionEnd() >= self.promptPosEnd: | ||
| return True | ||
| else: | ||
| return False | ||
| return ( | ||
| self.GetSelectionStart() != self.GetSelectionEnd() | ||
| and self.GetSelectionStart() >= self.promptPosEnd | ||
| and self.GetSelectionEnd() >= self.promptPosEnd | ||
| ) |
Author
There was a problem hiding this comment.
Function Shell.CanCut refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity) - Remove unnecessary casts to int, str, float or bool (
remove-unnecessary-cast) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
-1288
to
+1232
| if self.CanEdit() and editwindow.EditWindow.CanPaste(self): | ||
| return True | ||
| else: | ||
| return False | ||
| return bool(self.CanEdit() and editwindow.EditWindow.CanPaste(self)) |
Author
There was a problem hiding this comment.
Function Shell.CanPaste refactored with the following changes:
- Simplify boolean if expression (
boolean-if-exp-identity) - Replace if statement with if expression (
assign-if-exp)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!