Repository navigation
Implement the fn:collation-key XQuery function - #4435
Merged
dizzzz merged 11 commits intoJul 4, 2022
Merged
Conversation
adamretter
suggested changes
Jun 8, 2022
adamretter
left a comment
Contributor
There was a problem hiding this comment.
Just a few small issues with equality comparisons that need to be addressed in the tests.
Contributor
|
@chris-evolvedbinary Also could you please use the prefixes in your commit messages. If you look at the commit log you will see we use prefixes like |
dizzzz
approved these changes
Jun 10, 2022
dizzzz
left a comment
Member
There was a problem hiding this comment.
LGTM, one test case not correct
dizzzz
requested changes
Jun 10, 2022
dizzzz
left a comment
Member
There was a problem hiding this comment.
One testcase needs to be updated
adamretter
marked this pull request as draft
June 10, 2022 14:57
adamretter
force-pushed
the
feature/fn-collation-key#1,#2
branch
from
June 15, 2022 12:26
e418d2f to
fec9102
Compare
adamretter
marked this pull request as ready for review
June 15, 2022 12:28
Contributor
|
@dizzzz I think this is now ready |
adamretter
self-requested a review
June 15, 2022 14:11
adamretter
approved these changes
Jun 15, 2022
adamretter
left a comment
Contributor
There was a problem hiding this comment.
This now looks good to me :-)
Member
|
Still quite some testcases fail. Rerunning.... |
dizzzz
approved these changes
Jun 17, 2022
…parisons in fn:collation-key tests.
…ation-key() function.
adamretter
force-pushed
the
feature/fn-collation-key#1,#2
branch
from
June 24, 2022 15:00
a5601f0 to
a589379
Compare
…tion, and add BinaryValue.hashCode() method.
|
SonarCloud Quality Gate failed. |
dizzzz
approved these changes
Jul 4, 2022
12 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the
fn:collation-key()function.Reference:
Type of tests:
exist-core/src/test/xquery/xquery3/fnCollationKey.xqmThis passes all XQTS tests for
fn-collation-keyapart from the two tests:collation-key-105andcollation-key-206. These tests require that eXist-db supports themerge-lastoption when callingmap:merge. These remaining two tests tests should pass once the PR #3738 is merged to eXist-db.--
This open source contribution to the eXist-db project was commissioned by the Office of the Historian, U.S. Department of State, https://history.state.gov/.