Skip to content

Some general pytest cleanup#1021

Merged
djeebus merged 1 commit into
mainfrom
pytest-timeout
Nov 14, 2025
Merged

Some general pytest cleanup#1021
djeebus merged 1 commit into
mainfrom
pytest-timeout

Conversation

@djeebus
Copy link
Copy Markdown
Contributor

@djeebus djeebus commented Nov 13, 2025 •
edited
Loading

  • Individual tests must complete in less than 5 minutes
  • Add a make test option that runs tests
  • Upgrade poetry to 2.1.1 (the lock file was generated by this version, so this just matches what we already expect)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Nov 13, 2025

⚠️ No Changeset found

Latest commit: 8c885e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ValentaTomas
ValentaTomas reviewed Nov 13, 2025
View reviewed changes
Comment thread packages/python-sdk/pytest.ini
skip_debug: skip test if E2B_DEBUG is set.

asyncio_mode=auto
addopts = "--import-mode=importlib" "--numprocesses=4"
Copy link
Copy Markdown
Member

@ValentaTomas ValentaTomas Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason for changing the numprocesses?

(In the past it might have been to reduce load?)

Copy link
Copy Markdown
Contributor Author

@djeebus djeebus Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configures options that are always added when running pytest. This option isn't super great locally, but is super useful when running CI, so I moved it into the Makefile. End result - running pytest won't parallelize by default, but CI will still use 4 processes

@djeebus djeebus merged commit d2e22e3 into main Nov 14, 2025
8 of 10 checks passed
@djeebus djeebus deleted the pytest-timeout branch November 14, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ValentaTomas ValentaTomas ValentaTomas approved these changes

@jakubno jakubno Awaiting requested review from jakubno jakubno is a code owner

@mishushakov mishushakov Awaiting requested review from mishushakov mishushakov is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djeebus @ValentaTomas