Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1209991789468715/task/1213982969677093?focus=true
Description
Remove backend check for hadTrial since we limited usage on Play Console
Steps to test this PR (subscriptions smoke test)
Pre steps
Free trial eligible
Subscription expired
VPN menu item
No UI changes
Note
Low Risk
Low risk: removes a redundant backend call and simplifies free-trial eligibility gating; behavior changes only in cases where the backend previously reported
hadTrialbut Play Console still exposes an intro offer.Overview
Removes the
v1/offer-statusAPI fromSubscriptionsServiceand deletes the associatedOfferStatusResponsemodel.RealSubscriptionsManager.isFreeTrialEligibleno longer queries the backend forhadTrial; free-trial eligibility is now determined solely by theprivacyProFreeTrialfeature flag and whether a matching free-trial offer is available from Google Play.Reviewed by Cursor Bugbot for commit 93b50cb. Bugbot is set up for automated code reviews on this repo. Configure here.