Allows the webhost used for OAuth to be specified#162
Merged
jiuyangzhao merged 1 commit intodropbox:masterfrom Oct 19, 2017
Merged
Allows the webhost used for OAuth to be specified#162jiuyangzhao merged 1 commit intodropbox:masterfrom
jiuyangzhao merged 1 commit intodropbox:masterfrom
Conversation
Allows the webhost used for oauth to be specified
jiuyangzhao
reviewed
Oct 19, 2017
| String[] alreadyAuthedUids, | ||
| String sessionId, | ||
| String webHost) { | ||
| if (!AuthActivity.checkAppBeforeAuth(context, appKey, true /*alertUser*/)) { |
Contributor
There was a problem hiding this comment.
We can just add a new function and don't break existing public function signiture.
Author
There was a problem hiding this comment.
this shouldn't break the existing public signature; it just overloads the method with another. The original signature is unchanged in the method above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.