Fix failing filter test#112
Merged
Merged
Conversation
calebcase
reviewed
Jan 3, 2020
|
|
||
| [tox] | ||
| envlist = py36, py38, pypy | ||
| envlist = py27, py36, py38, pypy |
Collaborator
There was a problem hiding this comment.
Version 2 doesn't support py27.
b4beac2 to
5d74d05
Compare
5d74d05 to
d4d236f
Compare
calebcase
approved these changes
Jan 26, 2020
Collaborator
Author
|
Merging, the only failure is the hypothesis timeout which was addressed seperately |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is blocking the 2.0 release, and this fixes it.
However the way I had to fix this test implies that the interface provided to filter functions has changed in 2.0. @calebcase ?