Initial work to enable EventPipe in Linux#86226
Merged
Merged
Conversation
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsCI check
|
jkotas
reviewed
May 16, 2023
elinor-fung
reviewed
May 17, 2023
davidwrighton
approved these changes
May 18, 2023
Member
davidwrighton
left a comment
There was a problem hiding this comment.
I've not reviewed the build system changes, as I'm not familiar with the details of how the nativeaot build system works.
jkotas
reviewed
May 18, 2023
elinor-fung
reviewed
May 18, 2023
Co-authored-by: Michal Strehovský <MichalStrehovsky@users.noreply.github.com>
jkotas
reviewed
May 22, 2023
elinor-fung
approved these changes
May 23, 2023
| EventPipeThreadHolder *thread_holder = pthread_getThreadHolder (); | ||
| #else | ||
| EventPipeThreadHolder *thread_holder = EventPipeAotThreadHolderTLS::getThreadHolder (); | ||
| #endif |
Member
There was a problem hiding this comment.
Is the platform difference something that could be encapsulated in EventPipeAotThreadHolderTLS? The name of that class makes me think it is intended to hide away implementation like that, so it seems odd to me that the caller has to do the split.
Contributor
Author
There was a problem hiding this comment.
EventPipeAotThreadHolderTLS class seems windows specific with ability to use of thread_local and the class destructor doing the cleanup.
Co-authored-by: Elinor Fung <elfung@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support to enable
EventPipein Unix. The new additions include:pthreadfor thread local storagePalGetCurrentThreadIdForLoggingto get the thread idgmtimeandgettimeofday(for milliseconds) to get system timedisambiguation_key