Skip to content

Update builds for microbundle v15#619

Merged
donmccurdy merged 1 commit intomainfrom
hotfix/microbundle-v15
Jul 10, 2022
Merged

Update builds for microbundle v15#619
donmccurdy merged 1 commit intomainfrom
hotfix/microbundle-v15

Conversation

@donmccurdy
Copy link
Copy Markdown
Owner

@donmccurdy donmccurdy commented Jul 10, 2022

@donmccurdy donmccurdy added bug Something isn't working package:core labels Jul 10, 2022
@donmccurdy donmccurdy mentioned this pull request Jul 10, 2022
Closed
@donmccurdy
Copy link
Copy Markdown
Owner Author

donmccurdy commented Jul 10, 2022

Root cause of #611, as far as I can tell:

  1. the update to microbundle v15 changed default output to .mjs
  2. builds did not include a step to clean the output folder, so old .js files remained
  3. tests resolved new files locally (somehow? different bundler?) but some bundlers resolved to the old files, mismatched to dependencies, and hit errors.

@donmccurdy donmccurdy merged commit 9f63beb into main Jul 10, 2022
@donmccurdy donmccurdy deleted the hotfix/microbundle-v15 branch July 10, 2022 22:56
@donmccurdy donmccurdy mentioned this pull request Jul 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working package:core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

@gltf-transform/extensions: 'KTX2Model' was not found in 'ktx-parse'

1 participant

@donmccurdy