Skip to content

Moved examples under eSignature, added private.key to .gitignore, add…#16

Merged
robkkni merged 3 commits into
masterfrom
private
Aug 27, 2020
Merged

Moved examples under eSignature, added private.key to .gitignore, add…#16
robkkni merged 3 commits into
masterfrom
private

Conversation

@robkkni
Copy link
Copy Markdown
Contributor

@robkkni robkkni commented Aug 25, 2020

…ed quickstart to ds_config_sample, moved eg001_embedded_signing folder under app.

…ed quickstart to ds_config_sample, moved eg001_embedded_signing folder under app.
@robkkni robkkni requested review from AaronWDS and InbarGazit August 25, 2020 07:41
Comment thread app/ds_config_sample.py Outdated
Copy link
Copy Markdown
Contributor

@AaronWDS AaronWDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to move the example 1 back into the folder with the other eSignature examples. Originally I was saying to update the index template file instead to check for the quickstart value and if the user is logged in. but at the moment I cannot confirm if you can send a redirect or run some arbitrary python code to get the redirect moving from within the template file. We should sync offline to discuss approaches

Comment thread app/__init__.py Outdated
Comment thread app/eg001_embedded_signing/controller.py
Comment thread app/eg001_embedded_signing/views.py
Copy link
Copy Markdown
Contributor

@AaronWDS AaronWDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much better, lgtm 👍

@robkkni robkkni merged commit 6118761 into master Aug 27, 2020
paigesrossi added a commit that referenced this pull request Feb 19, 2021
adding Click examples back to the launcher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants