Skip to content

Fetchmail cleanup#2855

Closed
casperklein wants to merge 4 commits into
docker-mailserver:masterfrom
casperklein:fetchmail
Closed

Fetchmail cleanup#2855
casperklein wants to merge 4 commits into
docker-mailserver:masterfrom
casperklein:fetchmail

Conversation

@casperklein
Copy link
Copy Markdown
Member

@casperklein casperklein commented Oct 23, 2022

Description

While working on recent PRs and now using fetchmail myself, I noticed a few things that bugs me.

  1. Fetchmail is heavily verbose in mail.log. This leads to a lot of log entries on each poll:

    Details
    fetchmail: 6.4.16 querying pop.gmx.net (protocol POP3) at Sun Oct 23 12:31:02 2022: poll started
    Trying to connect to 212.227.17.185/995...connected.
    fetchmail: Loaded OpenSSL library 0x101010ef newer than headers 0x101010bf, trying to continue.
    fetchmail: Server certificate:
    fetchmail: Issuer Organization: T-Systems International GmbH
    fetchmail: Issuer CommonName: TeleSec ServerPass Extended Validation Class 3 CA
    fetchmail: Subject CommonName: mail.gmx.net
    fetchmail: Subject Alternative Name: mail.gmx.net
    fetchmail: Subject Alternative Name: mail.gmx.de
    fetchmail: Subject Alternative Name: smtp.gmx.net
    fetchmail: Subject Alternative Name: smtp.gmx.de
    fetchmail: Subject Alternative Name: imap.gmx.net
    fetchmail: Subject Alternative Name: imap.gmx.de
    fetchmail: Subject Alternative Name: pop.gmx.net
    fetchmail: Subject Alternative Name: pop.gmx.de
    fetchmail: pop.gmx.net key fingerprint: 37:6D:93:28:DE:58:A2:7B:6D:61:07:76:1F:56:70:6F
    fetchmail: SSL/TLS: using protocol TLSv1.3, cipher TLS_AES_256_GCM_SHA384, 256/256 secret/processed bits
    fetchmail: POP3< +OK POP server ready H migmx006 1N6tSP-1pA9Gr1Tln-018FlG
    fetchmail: POP3> CAPA
    fetchmail: POP3< +OK Capability list follows
    fetchmail: POP3< TOP
    fetchmail: POP3< UIDL
    fetchmail: POP3< USER
    fetchmail: POP3< SASL PLAIN
    fetchmail: POP3< IMPLEMENTATION trinity
    fetchmail: POP3< .
    fetchmail: POP3> USER *****@gmx.de
    fetchmail: POP3< +OK password required for user "*****@gmx.de"
    fetchmail: POP3> PASS *
    fetchmail: POP3< +OK mailbox "*****@gmx.de" has 0 messages (0 octets) H migmx006
    fetchmail: POP3> STAT
    fetchmail: POP3< +OK 0 0
    fetchmail: No mail for *****@gmx.de at pop.gmx.net
    fetchmail: POP3> QUIT
    fetchmail: POP3< +OK POP server signing off
    fetchmail: 6.4.16 querying pop.gmx.net (protocol POP3) at Sun Oct 23 12:31:02 2022: poll completed
    fetchmail: sleeping at Sun Oct 23 12:31:02 2022 for 300 seconds
    
  2. There were some defaults prepended to each user supplied fetchmail config:

set syslog: We log to files, no reason to also log to syslog.
set daemon 300: We already set the interval when calling fetchmail from supervisor.

These are no useful defaults IMO and should be removed. If needed, they can be configured in a users custom fetchmail configuration.

Edit: While answering #2858 I recognized, why the set syslog line makes sense, and should kept?

Edit2: Having a sane default like set daemon 300 doesn't hurt. I will undo all changes related to point 2, so only point 1 remains: fb315e5

Edit3: New clean PR #2859

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change that does improve existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@casperklein casperklein self-assigned this Oct 23, 2022
@casperklein casperklein added area/scripts kind/improvement Improve an existing feature, configuration file or the documentation area/configuration (file) service/fetchmail labels Oct 23, 2022
@casperklein casperklein added this to the v11.3.0 milestone Oct 23, 2022
@casperklein casperklein deleted the fetchmail branch October 29, 2022 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/configuration (file) area/scripts kind/improvement Improve an existing feature, configuration file or the documentation service/fetchmail

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant