Fetchmail cleanup#2855
Closed
casperklein wants to merge 4 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While working on recent PRs and now using fetchmail myself, I noticed a few things that bugs me.
Fetchmail is heavily verbose in
mail.log. This leads to a lot of log entries on each poll:Details
There were some defaults prepended to each user supplied fetchmail config:
set syslog: We log to files, no reason to also log to syslog.set daemon 300: We already set the interval when calling fetchmail from supervisor.These are no useful defaults IMO and should be removed. If needed, they can be configured in a users custom fetchmail configuration.
Edit: While answering #2858 I recognized, why the
set syslogline makes sense, and should kept?Edit2: Having a sane default like
set daemon 300doesn't hurt. I will undo all changes related to point 2, so only point 1 remains: fb315e5Edit3: New clean PR #2859
Type of change
Checklist:
docs/)