Skip to content

Update Dockerfile - #257

Closed
JermineHu wants to merge 1 commit into
docker-library:masterfrom
JermineHu:patch-1
Closed

Update Dockerfile#257
JermineHu wants to merge 1 commit into
docker-library:masterfrom
JermineHu:patch-1

Conversation

@JermineHu

Copy link
Copy Markdown

The code ONBUILD COPY . /usr/src/app has been included requirements.txt file.

The code `ONBUILD COPY . /usr/src/app `  has been included requirements.txt file.
@yosifkit

Copy link
Copy Markdown
Member

Onbuild variants have been deprecated in docker-library/docs#911. Besides, the order of the COPY, RUN, COPY is on purpose, so that when code is changed that doesn't affect requirements.txt the user doesn't have to wait for the pip install again when rebuilding the image.

Related issue #196.

@yosifkit yosifkit closed this Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants