Skip to content

include non-null property for json serialization - #966

Merged
KostyaSha merged 1 commit into
docker-java:masterfrom
fengxx:service_spec_json_props
Dec 14, 2017
Merged

KostyaSha merged 1 commit into
docker-java:masterfrom
fengxx:service_spec_json_props

Conversation

@fengxx

@fengxx fengxx commented Dec 14, 2017 •

Copy link
Copy Markdown
Contributor
  • add JsonInclude annotation to include non-null property for json serialization, to have a clean output

This change is Reviewable

@codecov-io

codecov-io commented Dec 14, 2017 •

Copy link
Copy Markdown

Codecov Report

Merging #966 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #966   +/-   ##
=======================================
  Coverage   60.53%   60.53%           
=======================================
  Files         429      429           
  Lines        8476     8476           
  Branches      538      538           
=======================================
  Hits         5131     5131           
  Misses       3048     3048           
  Partials      297      297
Impacted Files Coverage Δ
...com/github/dockerjava/api/model/ResourceSpecs.java 9.09% <ø> (ø) ⬆️
...java/com/github/dockerjava/api/model/TaskSpec.java 3.84% <ø> (ø) ⬆️
...com/github/dockerjava/api/model/ContainerSpec.java 2.63% <ø> (ø) ⬆️
...a/com/github/dockerjava/api/model/ServiceSpec.java 3.84% <ø> (ø) ⬆️
.../com/github/dockerjava/api/model/EndpointSpec.java 9.09% <ø> (ø) ⬆️
...com/github/dockerjava/netty/InvocationBuilder.java 90.86% <0%> (-0.92%) ⬇️
...a/com/github/dockerjava/api/command/GraphData.java 100% <0%> (+12.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d0f57...b3fbace. Read the comment docs.

@KostyaSha KostyaSha added this to the 3.1.0 milestone Dec 14, 2017
@KostyaSha
KostyaSha merged commit 65a527d into docker-java:master Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants