Skip to content

Update DockerClientBuilder.java #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcuslinke merged 1 commit into from
Nov 13, 2014
Merged

Update DockerClientBuilder.java #90

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update DockerClientBuilder.java 
Added method to allow changing the ClassPath used by ServiceLoader.
  • Loading branch information
Robert Szymczak committed Nov 12, 2014
commit df7294a86bbeaea3f4a6d33b7ca46c220e9a0971
6 changes: 6 additions & 0 deletions src/main/java/com/github/dockerjava/core/DockerClientBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,12 @@ public DockerClientBuilder withDockerCmdExecFactory(
this.dockerCmdExecFactory = dockerCmdExecFactory;
return this;
}

public DockerClientBuilder withServiceLoaderClassPath(ClassPath classPath)
Copy link
Copy Markdown
Contributor

@albers albers Nov 13, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code does not compile. Should probably be ClassLoader.

{
serviceLoader = ServiceLoader.load(DockerCmdExecFactory.class, classPath);
return this;
}

public DockerClient build() {
if(dockerCmdExecFactory != null) {
Expand Down