Skip to content

Add support for private repositories and pull/push authentication #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexec merged 19 commits into from
Nov 9, 2014
Merged

Add support for private repositories and pull/push authentication #88

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
1543b0b
first draft of support for pulling and pushing from a private, authen…
alexec Nov 2, 2014
60dee43
AuthCmd now returns AuthResponse so you can tell if you need to autho…
alexec Nov 2, 2014
f4d3476
create a private authenticated local repository
alexec Nov 2, 2014
402fa2b
updated default username/password to be just "dockerjava" as hyphen i…
alexec Nov 2, 2014
e5af72c
added debugging to PushImageCmdImplTest as it is failing
alexec Nov 2, 2014
6c84ba3
removed file accidentally committed
alexec Nov 2, 2014
f0f232f
fixed twitch tests in DockerClientImpl
Nov 3, 2014
bbeb6dc
make version default to null (i.e. absent and autodetect)
Nov 4, 2014
3388519
pem files for SSL
Nov 4, 2014
e06b2a4
moved files around
Nov 4, 2014
6f28a24
Update README.md
alexec Nov 4, 2014
f1573c0
Update README.md
alexec Nov 4, 2014
b50bb58
1
alexec Nov 8, 2014
1ad712e
1
alexec Nov 8, 2014
15ce5e0
1
alexec Nov 8, 2014
05d8d03
moved to own project
alexec Nov 9, 2014
2c6ab38
tidy up of files
alexec Nov 9, 2014
7aaefb4
Merge branch 'master' into serverAddress
alexec Nov 9, 2014
9503bc0
updated README.md
alexec Nov 9, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed twitch tests in DockerClientImpl
  • Loading branch information
alex.collins committed Nov 3, 2014
commit f0f232fc3996381c4003dc2a31084a806edab723
2 changes: 0 additions & 2 deletions src/main/java/com/github/dockerjava/core/DockerClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,6 @@ private DockerCmdExecFactory getDockerCmdExecFactory() {

public AuthConfig authConfig() {
checkNotNull(dockerClientConfig.getUsername(), "Configured username is null.");
checkNotNull(dockerClientConfig.getPassword(), "Configured password is null.");
checkNotNull(dockerClientConfig.getEmail(), "Configured email is null.");
checkNotNull(dockerClientConfig.getServerAddress(), "Configured serverAddress is null.");

AuthConfig authConfig = new AuthConfig();
Expand Down
2 changes: 1 addition & 1 deletion src/test/java/com/github/dockerjava/core/DockerClientConfigTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public void equals() throws Exception {
public void environmentDockerHost() throws Exception {

// given docker host in env
Map<String, String> env = new HashMap<String, String>(System.getenv());
Map<String, String> env = new HashMap<String, String>();
env.put("DOCKER_HOST", "tcp://baz:8768");

// when you build a config
Expand Down