Skip to content

Allow multiple port bindings per ExposedPort #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcuslinke merged 2 commits into from
Oct 26, 2014
Merged

Allow multiple port bindings per ExposedPort #82

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1f31cd
Document current deserialization of Ports with a test
albers Oct 20, 2014
4571e99
Allow multiple port bindings per exposed port
albers Oct 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Document current deserialization of Ports with a test
  • Loading branch information
@albers
albers committed Oct 26, 2014
commit d1f31cdfb0716c976eff6051f00fc8896cfc75c8
33 changes: 33 additions & 0 deletions src/test/java/com/github/dockerjava/api/model/PortsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.github.dockerjava.api.model;

import static org.testng.Assert.assertEquals;

import java.util.Map;

import org.testng.annotations.Test;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.github.dockerjava.api.model.Ports.Binding;

public class PortsTest {
private final ObjectMapper objectMapper = new ObjectMapper();

@Test
public void deserializingPortWithMultipleBindingsReturnsFirstBinding() throws Exception {
String json = "{\"80/tcp\":[{\"HostIp\":\"10.0.0.1\",\"HostPort\":\"80\"},{\"HostIp\":\"10.0.0.2\",\"HostPort\":\"80\"}]}";
Ports ports = objectMapper.readValue(json, Ports.class);
Map<ExposedPort, Binding> bindings = ports.getBindings();
assertEquals(bindings.size(), 1);

Binding binding = bindings.get(ExposedPort.tcp(80));
assertEquals(binding, new Binding("10.0.0.1", 80));
}

@Test
public void serializePort() throws Exception {
Ports ports = new Ports(ExposedPort.tcp(80), new Binding("10.0.0.1", 80));
String expectedJson = "{\"80/tcp\":[{\"HostIp\":\"10.0.0.1\",\"HostPort\":\"80\"}]}";
assertEquals(objectMapper.writeValueAsString(ports), expectedJson);
}

}