Skip to content

Move slow tests to integration test phase, enable tests by default #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcuslinke merged 2 commits into from
Oct 21, 2014
Merged

Move slow tests to integration test phase, enable tests by default #79

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea72d6b
Allow fast tests to execute during standard build
albers Oct 20, 2014
843600d
Run all tests by default, integration tests can be disabled.
albers Oct 20, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Run all tests by default, integration tests can be disabled. 
This changes the build to a more standard Maven way.
  • Loading branch information
@albers
albers committed Oct 20, 2014
commit 843600dd4ce5ed2fd33de14bd8dd9f618918164e
11 changes: 6 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,15 @@ Developer forum for [docker-java](https://groups.google.com/forum/?hl=de#!forum/
* Maven 3.0.5
* Docker daemon running

Some of the tests are using a localhost instance of Docker and require manual setup.
In order to enable an easy standard build, these integration tests are disabled by default.
The Maven build includes integration tests which are using a localhost instance of Docker and require manual setup. Make sure you have a local Docker daemon running and then provide your https://registry.hub.docker.com/account/login/ information via system properties:

To run the full set of tests, make sure you have a local Docker daemon running and hten provide your https://registry.hub.docker.com/account/login/ information via system properties:
$ mvn clean install -Ddocker.io.username=... -Ddocker.io.password=... -Ddocker.io.email=...

$ mvn clean install -DskipITs=false -Ddocker.io.username=... -Ddocker.io.password=... -Ddocker.io.email=...
_If your Docker server is remote, add its URL like this: `-Ddocker.io.url=http://...:2375`._

If you are using a remote Docker server, add its URL like this: `-Ddocker.io.url=http://...:2375`.
If you do not have access to a Docker server or just want to execute the build quickly, you can run the build without the integration tests:

$ mvn clean install -DskipITs

By default Docker server is using UNIX sockets for communication with the Docker client, however docker-java
client uses TCP/IP to connect to the Docker server, so you will need to make sure that your Docker server is
Expand Down
3 changes: 0 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@
</developers>

<properties>
<skipITs>true</skipITs>

<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<jdk.debug>true</jdk.debug>
Expand Down Expand Up @@ -342,7 +340,6 @@
<goal>verify</goal>
</goals>
<configuration>
<skipITs>${skipITs}</skipITs>
<groups>integration</groups>
<includes>
<include>**/*Test.java</include>
Expand Down