Skip to content

Bind.parse() fails when access mode is specified #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcuslinke merged 3 commits into from
Sep 28, 2014
Merged

Bind.parse() fails when access mode is specified #63

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5eaf1b
Parsing serialized Bind with given access mode fails
albers Sep 27, 2014
1b74f6c
Fix and improve parsing of serialized Bind
albers Sep 27, 2014
ed92136
Parsing invalid serialized Bind throws IllegalArgumentException
albers Sep 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Parsing serialized Bind with given access mode fails 
readWrite() and readOnly() both fail due to implementation errors in
Bind.parse()
  • Loading branch information
@albers
albers committed Sep 28, 2014
commit f5eaf1b0b02efea9b67379e1d1a8b885de39ce38
38 changes: 38 additions & 0 deletions src/test/java/com/github/dockerjava/api/model/BindTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package com.github.dockerjava.api.model;

import static org.testng.Assert.assertEquals;

import org.testng.annotations.Test;

public class BindTest {

@Test
public void parseUsingDefaultAccessMode() {
Bind bind = Bind.parse("/host:/container");
assertEquals(bind.getPath(), "/host");
assertEquals(bind.getVolume().getPath(), "/container");
assertEquals(bind.isReadOnly(), false);
}

@Test
public void parseReadWrite() {
Bind bind = Bind.parse("/host:/container:rw");
assertEquals(bind.getPath(), "/host");
assertEquals(bind.getVolume().getPath(), "/container");
assertEquals(bind.isReadOnly(), false);
}

@Test
public void parseReadOnly() {
Bind bind = Bind.parse("/host:/container:ro");
assertEquals(bind.getPath(), "/host");
assertEquals(bind.getVolume().getPath(), "/container");
assertEquals(bind.isReadOnly(), true);
}

@Test(expectedExceptions = RuntimeException.class)
public void parseInvalidAccessMode() {
Bind.parse("/host:/container:xx");
}

}