Skip to content

Remove special-case for one ":" from PullCommand #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcuslinke merged 2 commits into from
Aug 7, 2014
Merged

Remove special-case for one ":" from PullCommand #38

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5a0f74
Remove special-case for one ":" from PullCommand
hmrm Aug 6, 2014
c176263
Merge remote-tracking branch 'upstream/master'
hmrm Aug 7, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove special-case for one ":" from PullCommand 
This special treatment breaks images with registries with a port
specified, e.g. my-docker-registry:5000/my-namespace/my-image
  • Loading branch information
@hmrm
hmrm committed Aug 6, 2014
commit d5a0f74780289dba152c3752c464196c633b03ff
7 changes: 0 additions & 7 deletions src/main/java/com/github/dockerjava/client/command/PullImageCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,6 @@ public String toString() {
protected ClientResponse impl() {
Preconditions.checkNotNull(repository, "Repository was not specified");

if (StringUtils.countMatches(repository, ":") == 1) {
String repositoryTag[] = StringUtils.split(repository, ':');
repository = repositoryTag[0];
tag = repositoryTag[1];

}

MultivaluedMap<String, String> params = new MultivaluedMapImpl();
params.add("tag", tag);
params.add("fromImage", repository);
Expand Down