Expose inspectSwarmNodeCmd through DockerClient - #2673
Open
kush2439p wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InspectSwarmNodeCmdthroughDockerClientRoot cause
The command interface, implementation, and executor already existed, but
DockerClientandDockerClientDelegatedid not expose a factory method. Consumers therefore could not invoke the command through the public client API.Impact
Consumers can now call
dockerClient.inspectSwarmNodeCmd(nodeId).exec()consistently with the existing list, update, and remove swarm-node commands.Verification
mvn -pl docker-java-api,docker-java-core -am test -DskipITs -Dmaven.javadoc.skip=truemvn -pl docker-java -am test-compile -DskipITs -Dmaven.javadoc.skip=truegit diff --checkmvn clean install -DskipITspassed through the API, core, transport TCK, Netty, and Jersey modules; it stopped in the existing OkHttp Docker-dependent TCK because no local Docker daemon was available.Fixes #2373