Skip to content

Fix httpclient memory leak risk #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsideup merged 2 commits into from
Mar 26, 2021
Merged

Fix httpclient memory leak risk #1560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3dffc0f
Fix memory leak risk by using `disableConnectionState()` to disable h…
Mar 16, 2021
b2a818c
Merge branch 'master' into master
internalerror Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...tpclient5/src/main/java/com/github/dockerjava/httpclient5/ApacheDockerHttpClientImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ protected ApacheDockerHttpClientImpl(
httpClient = HttpClients.custom()
.setRequestExecutor(new HijackingHttpRequestExecutor(null))
.setConnectionManager(connectionManager)
.disableConnectionState()
.build();
}

Expand Down
3 changes: 2 additions & 1 deletion docs/getting_started.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ DockerClientConfig config = ...;
DockerHttpClient httpClient = new ApacheDockerHttpClient.Builder()
.dockerHost(config.getDockerHost())
.sslConfig(config.getSSLConfig())
.maxConnections(100)
.build();
```

Expand Down Expand Up @@ -118,4 +119,4 @@ DockerClient dockerClient = DockerClientImpl.getInstance(config, httpClient);
Once you have it, you can start executing Docker commands:
```java
dockerClient.pingCmd().exec();
```
```