Create Identifier type. - #146
Merged
Merged
Conversation
Contributor
|
@magnayn Shouldn't we make use of |
Contributor
Author
|
You could - IME Identifiers often cause mistakes in clients -- I just didn't want the scope of this PR to go changing APIs that may have some pain for people to change.. |
Contributor
Author
|
Rebased because of merge conflict |
Contributor
|
Could you add some basic tests for |
at various points (e.g: 10.0.0.1:8000/mybuild:1234) Signed-off-by: Nigel Magnay <nigel.magnay@gmail.com>
Signed-off-by: Nigel Magnay <nigel.magnay@gmail.com>
Contributor
Author
|
added some tests |
Contributor
|
@magnayn Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker 'Identifiers' are easily to get wrong, as everything is a string and APIs that just take 'string' are therefore prone to error.
Users are used to tags looking like the following
tag
tag:label
host/tag
host/tag:label
host:port/tag
host:port/tag:label
Create a class to parse this into the 'repository' side and the (optional) tag side.