Skip to content

plugin command -create,inspect,list,remove- - #1363

Closed
DomTheDon12 wants to merge 3 commits into
docker-java:masterfrom
DomTheDon12:master
Closed

plugin command -create,inspect,list,remove-#1363
DomTheDon12 wants to merge 3 commits into
docker-java:masterfrom
DomTheDon12:master

Conversation

@DomTheDon12

Copy link
Copy Markdown

Plugin command support

@DomTheDon12 DomTheDon12 reopened this Apr 12, 2020
@DomTheDon12

Copy link
Copy Markdown
Author

Hi!
I'm a university student, and this was my task to do in one of our courses. Can you help me what's the problem?

@DomTheDon12

Copy link
Copy Markdown
Author

Anyone?

@trajano

trajano commented Apr 17, 2020

Copy link
Copy Markdown
Contributor

@DomTheDon12 I think something is wrong with the Travis build itself. #1366 just adds enums and the build fails.

@DomTheDon12

DomTheDon12 commented Apr 17, 2020

Copy link
Copy Markdown
Author

@trajano I'm new at docker-java. How can I try my code (plugin commands) if it's working or not? Can you help me with that?

@trajano

trajano commented May 23, 2020

Copy link
Copy Markdown
Contributor

You may want to rebase and push again, I think they fixed the builds

@bsideup

bsideup commented May 29, 2020

Copy link
Copy Markdown
Member

Hi @DomTheDon12,

Thanks for working on this! Could you please add tests?

}
}
@Override
public ListPluginsCmd.Exec listPluginsCmdExec() { return delegate.listPluginsCmdExec(); }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the code style here and in other places:

Suggested change
public ListPluginsCmd.Exec listPluginsCmdExec() { return delegate.listPluginsCmdExec(); }
public ListPluginsCmd.Exec listPluginsCmdExec() {
return delegate.listPluginsCmdExec();
}

@stale

stale Bot commented Jun 28, 2020

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot closed this Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants