Skip to content

Utility classes and streamed JSON representations#131

Merged
marcuslinke merged 4 commits into
docker-java:masterfrom
magnayn:pr3
Feb 5, 2015
Merged

Utility classes and streamed JSON representations#131
marcuslinke merged 4 commits into
docker-java:masterfrom
magnayn:pr3

Conversation

@magnayn

@magnayn magnayn commented Jan 21, 2015

Copy link
Copy Markdown
Contributor

I have some additional commits to come that build on these.

Tag parameters are frequently mis-parsed in client code - provide a mechanism to do so.
Create representations for streamed JSON object types.

@marcuslinke

Copy link
Copy Markdown
Contributor

@magnayn I would like to ask you to enrich this PR with these additional commits first please. Don't want to merge incomplete code into master. Thanks!

from commands. Create representations for them.

Signed-off-by: Nigel Magnay <nigel.magnay@gmail.com>
over in a typed fashion so that clients can read out the responses.

Use Iterable so the response does not have to be 'complete' before
consuming.

Derive from InputStream to maintain backwards compatibility and for clients
that don't want to parse the response.

Signed-off-by: Nigel Magnay <nigel.magnay@gmail.com>
Signed-off-by: Nigel Magnay <nigel.magnay@gmail.com>
Signed-off-by: Nigel Magnay <nigel.magnay@gmail.com>
@magnayn

magnayn commented Feb 3, 2015

Copy link
Copy Markdown
Contributor Author

BuildImage and PushImage now more easily consumable by clients.

marcuslinke added a commit that referenced this pull request Feb 5, 2015
Utility classes and streamed JSON representations
@marcuslinke marcuslinke merged commit 62a608d into docker-java:master Feb 5, 2015
@marcuslinke

Copy link
Copy Markdown
Contributor

@magnayn Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants