Skip to content

918 - fixing jackson unrecognized field exceptions via @JsonIgnorePro… - #1239

Closed
darinhoward wants to merge 1 commit into
docker-java:masterfrom
darinhoward:918
Closed

darinhoward wants to merge 1 commit into
docker-java:masterfrom
darinhoward:918

Conversation

@darinhoward

@darinhoward darinhoward commented Sep 4, 2019 •

Copy link
Copy Markdown

918 - fixing jackson unrecognized field exceptions via @JsonIgnorePro…


This change is Reviewable

@KostyaSha

Copy link
Copy Markdown
Member

@bsideup are you ok?)

@bsideup

bsideup commented Sep 4, 2019

Copy link
Copy Markdown
Member

@KostyaSha No. We agreed to have a freeze to merge #1235. Everything else should be merged after.

@bsideup

bsideup commented Sep 4, 2019

Copy link
Copy Markdown
Member

Also, this behaviour (fail on unknown properties) can be disabled in the ObjectMapper instead of putting an annotation on each class

@darinhoward

Copy link
Copy Markdown
Author

@bsideup I can alter if needed, this update was done to be as similar with existing jackson/model configuration.

@bsideup

bsideup commented Jan 26, 2020

Copy link
Copy Markdown
Member

Thanks a lot for your time!

DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES is disabled globally now and unfortunately makes this PR obsolete.

@bsideup bsideup closed this Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants