Reverts create container cmd regression. - #1203
Merged
KostyaSha merged 3 commits intoJun 25, 2019
Merged
Conversation
Summary: - Adds Binds, Links, Network Mode, Port Bindings, Priviliged, VolumesFrom, PublishAllPorts, ExtraHosts related methods to CreateContainerCmd interface and related interface. This was done so that the test-containers project can bump it's docker-java dependency for support to the latest docker version. See testcontainers/testcontainers-java#1340 for more.
KostyaSha
reviewed
Jun 18, 2019
CapAdd/CapDrop methods Manually tested that test containers repository passes gradle check process used by their CI process.
Author
|
Failing build https://travis-ci.org/docker-java/docker-java/jobs/547180117#L3488 Any clue/help you could provide? |
Author
|
Tests pass if I add @JsonIgnore to |
Author
|
I can not reproduce the CI failing tests locally, are they flaky? |
Member
it's ok |
This was referenced Jul 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
Binds,Links,NetworkMode,PortBindings,Privileged,VolumesFrom,PublishAllPorts,ExtraHosts,CapAddandCapDroprelated methods toCreateContainerCmdinterface and related implementation.This was done so that the test-containers project can bump its docker-java dependency to support the latest docker version.
See testcontainers/testcontainers-java#1340 for more.
Tested change by locally installing this branch of docker-java and running the updated test-containers codebase's gradle check process similarly to the repo's CI
This change is