Repository navigation
Use Base64Url instead of Base64 - #1146
Merged
Merged
Conversation
|
(Closes #1145) |
Member
|
ALL tests failed (should fail only 2 variants), need to be investigated |
Contributor
Author
|
It looks, that Base64 from Apache Commons omits padding. I've used Base64 from Guava instead. |
Contributor
Author
|
Now almost all tests are green. There are some failed tests on 2 workers with Swarm, but similar errors are in previous pipelines. |
Contributor
Author
|
Now it should be ok. Could You please merge it manually? |
This was referenced Jan 15, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docker is using Base64Url to encode
X-Registry-Authheader. It isn't documented anywhere, but we could check it in source code (for example here: https://github.com/docker/docker-ce/blob/10e40bd1548f69354a803a15fde1b672cc024b91/components/cli/cli/command/registry.go#L47).Currently some passwords doesn't work with this library. For example password
a!?testpasswordwill be encoded toYSE/dGVzdHBhc3N3b3Jkand will be rejected by Docker registry (because it should be encoded toYSE_dGVzdHBhc3N3b3Jk.This change is