Skip to content

update Listservices filter - #1002

Merged
KostyaSha merged 1 commit into
docker-java:masterfrom
fengxx:bugfix/services_filter
Mar 12, 2018
Merged

update Listservices filter#1002
KostyaSha merged 1 commit into
docker-java:masterfrom
fengxx:bugfix/services_filter

Conversation

@fengxx

@fengxx fengxx commented Mar 9, 2018 •
edited by marcuslinke
Loading

Copy link
Copy Markdown
Contributor

add missing label filter for docker service

This change is Reviewable

KostyaSha
KostyaSha reviewed Mar 9, 2018
View reviewed changes
Comment thread src/main/java/com/github/dockerjava/api/command/ListServicesCmd.java Outdated
* @param names - Show only services with the given names
*/

ListServicesCmd withNameFilter(String... names);

@KostyaSha KostyaSha Mar 9, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

method with list already exist, why do you nead additional?

@fengxx fengxx Mar 10, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

existing signature is List, add Varargs to get consistent with existing ListTasksCmd

@KostyaSha KostyaSha Mar 11, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the idea is to stop using non collection types

@fengxx fengxx Mar 12, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, sometimes varargs is more convenient, e.g. withIdFilter(id) is convenient than cast to List withIdFilter(Collections.singletonList(id)), anyway, I removed the varargs

@fengxx
fengxx force-pushed the bugfix/services_filter branch from 0ad1f6d to 0918e79 Compare March 12, 2018 00:20
@codecov-io

codecov-io commented Mar 12, 2018

Copy link
Copy Markdown

Codecov Report

Merging #1002 into master will decrease coverage by 0.65%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
- Coverage   59.34%   58.68%   -0.66%     
==========================================
  Files         441      441              
  Lines        8699     8711      +12     
  Branches      540      540              
==========================================
- Hits         5162     5112      -50     
- Misses       3238     3298      +60     
- Partials      299      301       +2
Impacted Files Coverage Δ
...ub/dockerjava/core/util/ServiceFiltersBuilder.java 0% <ø> (ø) ⬆️
...b/dockerjava/core/command/ListServicesCmdImpl.java 0% <0%> (ø) ⬆️
...ain/java/com/github/dockerjava/api/model/Node.java 0% <0%> (-93.75%) ⬇️
...ckerjava/core/command/PullImageResultCallback.java 40.38% <0%> (-40.39%) ⬇️
...va/jaxrs/filter/ResponseStatusExceptionFilter.java 53.84% <0%> (-15.39%) ⬇️
.../github/dockerjava/api/model/PullResponseItem.java 50% <0%> (-12.5%) ⬇️
...ckerjava/api/command/InspectContainerResponse.java 71.62% <0%> (-12.17%) ⬇️
...ava/netty/handler/FramedResponseStreamHandler.java 84.48% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c036b...0918e79. Read the comment docs.

@KostyaSha KostyaSha added this to the 3.1.0-rc-2 milestone Mar 12, 2018
@KostyaSha
KostyaSha merged commit ecb014e into docker-java:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KostyaSha KostyaSha KostyaSha left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.1.0-rc-2

Development

Successfully merging this pull request may close these issues.

3 participants

@fengxx @codecov-io @KostyaSha