Fix initial watch sync for existing files - #14031
Open
ousamabenyounes wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ben Younes <2910651+ousamabenyounes@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixes #13725.
develop.watchinitial sync filtered host files by the service image's creation time. Existing files older than the image were therefore omitted at startup, even though later filesystem events synced them normally.Initial sync now copies every eligible watched file, while preserving ignore and bind-mount filtering. The obsolete image-time lookup is removed.
Test verification
RED on upstream
main(832673c8e445b5bf0bdb4963c7d7b3f81aa46da0):GREEN with this change:
The live Engine reproduction also changed from
No such file or directoryto successfully readinghellofrom/app/src/test.txtat watch startup.Validation
Full local validation suite replayed on upstream and this branch:
golangci-lint run --build-tags e2e ./...—0 issuespkg/composeand all baseline-green unit packages passpkg/watchtests fail on both upstream and this branch; no new failures