cli: print command errors before next-step hooks - #7175
Open
locker95 wants to merge 1 commit into
Open
Conversation
Error-hooks were writing "What's next" to stderr before main printed the failure, so the hint appeared above the actual error. Print the error first, then run hooks, and return a status-code-only error so main does not print it twice. Fixes docker#6973 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error hooks were printing "What's next" before the actual failure showed up on stderr (main prints the error after hooks return).
Print the command error first when hooks are enabled, then run the hooks, and return a status-code-only error so main doesn't print it a second time. Same treatment for the plugin path.
Fixes #6973