version: keep consistent RFC3339 BuildTime for --format json - #7174
Open
locker95 wants to merge 1 commit into
Open
version: keep consistent RFC3339 BuildTime for --format json#7174locker95 wants to merge 1 commit into
locker95 wants to merge 1 commit into
Conversation
Server.BuildTime previously kept the raw Engine detail string while Components[].Details.BuildTime was reformatted to ANSIC, so the same JSON document mixed layouts. Skip reformat for json output so Client, Server, and component BuildTime stay as ISO-8601; human templates still get ANSIC. Fixes docker#6727 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docker version --format jsonwas mixing timestamp layouts in one document: Client / component Details used ANSIC viareformatDate, whileServer.BuildTimekept the raw RFC3339 value from the Engine component (and never got the reformatted string).For
json/{{json .}}, skip reformatting so BuildTime fields stay ISO-8601. Default human output is unchanged (ANSIC), andServer.BuildTimenow matches the Engine component detail after reformat.Fixes #6727