docs: run host HTTP server in background for --add-host example - #7172
Open
locker95 wants to merge 1 commit into
Open
docs: run host HTTP server in background for --add-host example#7172locker95 wants to merge 1 commit into
locker95 wants to merge 1 commit into
Conversation
The previous example started python3 in the foreground, so the docker run step could not be entered in the same shell. Background the server (or use a second terminal) and stop it after the curl check. Fixes docker#5558 Signed-off-by: Dean Chen <862469039@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host-gateway example started
python3 -m http.serverin the foreground, so you couldn't rundocker runin the same shell without killing the server first.Background the server (or use another terminal), add
--rmon the container, and stop the server when you're done.Fixes #5558