Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

Fix scalar coercion (#1914) - #1929

Closed
23Tarandeep57 wants to merge 2 commits into
docarray:mainfrom
23Tarandeep57:main
Closed

23Tarandeep57 wants to merge 2 commits into
docarray:mainfrom
23Tarandeep57:main

Conversation

@23Tarandeep57

Copy link
Copy Markdown

This PR fixes Issue #1914, where scalar values (int, float, complex, bool, np.number) were not correctly coerced into NdArray or JaxArray. PR adds a complete test suite ensuring correct behavior for all scalar types

Root Cause:

np.ndarray(value) and jnp.ndarray(value) interpret numeric values as shapes, not as data. This resulted in:
-uninitialized arrays when value was an integer
-validation errors when value was a float
-no coercion for complex or boolean scalars

1. Updated NdArray validator

elif isinstance(value, (int, float, complex, bool, np.number)):
    arr_from_scalar = np.array([value])
    return cls._docarray_from_native(arr_from_scalar)

2. Updated JaxArray validator

elif isinstance(value, (int, float, complex, bool, np.number)):
    arr_from_scalar = jnp.array([value])
    return cls._docarray_from_native(arr_from_scalar)

3. New Tests added in test_ndarray.py

test_from_scalar_int
test_from_scalar_float
test_from_scalar_complex
test_from_scalar_bool
test_from_scalar_in_document

These tests confirm:
Scalars convert to (1,) shape, Values are preserved correctly , Dtypes are correct (int32/int64, float32/float64, complex, bool) ,Scalars work correctly when assigned as Document fields

…dArray and JaxArray

Signed-off-by: 23Tarandeep57 <23je1021@iitism.ac.in>
Signed-off-by: 23Tarandeep57 <23je1021@iitism.ac.in>
@23Tarandeep57 23Tarandeep57 closed this by deleting the head repository Dec 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant