Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

fix: fix summary of Doc with list - #1595

Merged
samsja merged 1 commit into
mainfrom
fix-doc-summary
May 31, 2023
Merged

samsja merged 1 commit into
mainfrom
fix-doc-summary

Conversation

@JoanFM

@JoanFM JoanFM commented May 31, 2023 •

Copy link
Copy Markdown
Member

Fixes the summary of Document when List is used. Get the type from annotations better than from the value in __fields__

@JoanFM
JoanFM requested a review from samsja May 31, 2023 07:31
@JoanFM
JoanFM force-pushed the fix-doc-summary branch from baa03db to 8337f2d Compare May 31, 2023 08:07
Signed-off-by: Joan Fontanals Martinez <joan.martinez@jina.ai>
@JoanFM
JoanFM force-pushed the fix-doc-summary branch from 8337f2d to b5e0a45 Compare May 31, 2023 08:21
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-fix-doc-summary--jina-docs.netlify.app 🎉

@samsja
samsja merged commit 5d0e24c into main May 31, 2023
@samsja
samsja deleted the fix-doc-summary branch May 31, 2023 08:41
@samsja samsja mentioned this pull request Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Field of type List[str] is shown as str in the output of DocList.summary

2 participants