Skip to content
This repository was archived by the owner on Sep 9, 2026. It is now read-only.

docs: add a tensor section to docs - #1576

Merged
JoanFM merged 22 commits into
mainfrom
docs-tensor-type
May 31, 2023
Merged

JoanFM merged 22 commits into
mainfrom
docs-tensor-type

Conversation

@samsja

@samsja samsja commented May 24, 2023 •

Copy link
Copy Markdown
Member

Context

I am adding a tensor section to the docs inside the data_type folder.

what will be in there:

  • tensor validation
  • tensor type coercion
  • DocVec tensor type
  • Tensor shape

the section: https://ft-docs-tensor-type--jina-docs.netlify.app/data_types/tensor/tensor/

Tanguyabel and others added 2 commits May 24, 2023 17:30
Signed-off-by: Tanguy Abel <tanguy.abel@gmail.com>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@samsja
samsja marked this pull request as ready for review May 25, 2023 08:38
@github-actions github-actions Bot added size/m and removed size/s labels May 25, 2023
@alexcg1

alexcg1 commented May 25, 2023

Copy link
Copy Markdown
Contributor

Can you run Grammarly on it @samsja ? I see issues even in the first line

Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
@alexcg1

alexcg1 commented May 25, 2023

Copy link
Copy Markdown
Contributor

I'll add my feedback after @JohannesMessner 's stuff is resolved

samsja added 2 commits May 30, 2023 11:45
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
samsja and others added 4 commits May 30, 2023 11:55
Co-authored-by: Johannes Messner <44071807+JohannesMessner@users.noreply.github.com>
Signed-off-by: samsja <55492238+samsja@users.noreply.github.com>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
samsja and others added 9 commits May 30, 2023 13:43
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Signed-off-by: samsja <55492238+samsja@users.noreply.github.com>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
@samsja
samsja requested a review from alexcg1 May 31, 2023 08:20
samsja added 2 commits May 31, 2023 11:03
Signed-off-by: samsja <sami.jaghouar@hotmail.fr>
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md Outdated
Comment thread docs/data_types/tensor/tensor.md
Co-authored-by: Alex Cureton-Griffiths <alexcg1@users.noreply.github.com>
Signed-off-by: samsja <55492238+samsja@users.noreply.github.com>
@samsja
samsja requested a review from alexcg1 May 31, 2023 10:46
@github-actions

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-docs-tensor-type--jina-docs.netlify.app 🎉

@JoanFM
JoanFM merged commit 1e41b5c into main May 31, 2023
@JoanFM
JoanFM deleted the docs-tensor-type branch May 31, 2023 11:28
@samsja samsja mentioned this pull request Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants